mbeckerle commented on code in PR #901:
URL: https://github.com/apache/daffodil/pull/901#discussion_r1080674461
##########
daffodil-core/src/main/scala/org/apache/daffodil/grammar/AlignedMixin.scala:
##########
@@ -138,7 +138,7 @@ trait AlignedMixin extends GrammarMixin { self: Term =>
// The separator is text in some encoding, might not be the same as this
term's encoding, and
// the alignment will be left where that text leaves it.
//
- private lazy val priorAlignmentApprox: AlignmentMultipleOf =
LV('priorAlignmentApprox) {
+ lazy val priorAlignmentApprox: AlignmentMultipleOf =
LV('priorAlignmentApprox) {
Review Comment:
I looked at padtest. The only term in there that would have
isKnownToBeAligned false is this sequence:
<xs:sequence dfdl:alignment="4" dfdl:alignmentUnits="bytes"/>
That would have it false. It would be true for all the elements.
I think that makes the point that a walker is needed so that a generator
will encounter this object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
