mbeckerle commented on code in PR #918:
URL: https://github.com/apache/daffodil/pull/918#discussion_r1081747901


##########
daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/dafext.xsd:
##########
@@ -101,6 +101,17 @@
   <xs:element name="tunables">
     <xs:complexType>
       <xs:all>
+        <xs:element name="allowBigIntegerBits" type="xs:boolean" 
default="true" minOccurs="0">
+          <xs:annotation>
+            <xs:documentation>
+              Daffodil allows the use of lengthUnits="bits" when the type is 
xs:integer and
+              xs:nonNegativeInteger even though this is prohibited by the 
specification. When
+              this tunable is true, a deprecation warning is emitted when this 
condition is
+              encountered. When this tunable is false, this condition will 
instead result in a
+              schema definition error.

Review Comment:
   There is a separate JIRA ticket for making SDW warnings include instructions 
on how to suppress them (mention the specific symbol needed to put into the 
config file). That will help with this issue. Also.
   
   This ticket or any that increases warnings users get, will need a release 
note. Probably generic one about how this release of Daffodil issues more 
warnings about non-portable aspects of DFDL usage, .... and how to suppress 
them. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to