stevedlawrence commented on PR #429: URL: https://github.com/apache/daffodil-vscode/pull/429#issuecomment-1402336564
What issue is this resolving? The ticket mentions #309, but that's a pull request and not an issue. Do you mean #165? As to this change, I have trouble following the logic with all the nested if statemens, which makes me think this might not be best approach. We've been okay with it so far, but it's honestly too much to follow and ensure that we're doing the right thing, and as things get even more complex I don't see this approach being maintainable. I think maybe a new algorithm is really needed to figure the correct context for autocompletion instead of just a bunch of if-statements. If you want to have a phone call or email thread to discuss some alternative approaches I'm happy to do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
