mbeckerle commented on code in PR #945:
URL: https://github.com/apache/daffodil/pull/945#discussion_r1096347811
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/NodeInfo.scala:
##########
@@ -535,15 +535,16 @@ object NodeInfo extends Enum {
protected def fromString(s: String): DataValueNumber
def fromXMLString(s: String): DataValueNumber = {
Review Comment:
I have seen pretty printers do this:
```
<foo>
6847
</foo>
```
And in schema-aware XML, that doesn't change the infoset. This insertion of
whitespace only causes problems when the type is xs:string. (Which is what the
CDATA bracketing or escaping all whitespace is for)
So for numbers I think it's not a problem to tolerate whitespace when
reading from XML.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
