stevedlawrence commented on code in PR #448:
URL: https://github.com/apache/daffodil-vscode/pull/448#discussion_r1113082504


##########
build/package/LICENSE:
##########
@@ -319,69 +236,108 @@ conditions of the following licenses.
     OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
     THE SOFTWARE.
 
-- 'os-paths' extension/dist/ext/extension.js
-  This product bundles 'os-paths' from the above files.
-  These files are available under the MIT License:
-
+- 'ansi-regex' in extension/dist/ext/extension.js
+- 'ansi-styles' in extension/dist/ext/extension.js
+- 'is-fullwidth-code-point' in extension/dist/ext/extension.js
+- 'string-width' in extension/dist/ext/extension.js
+- 'wrap-ansi' in extension/dist/ext/extension.js
+  This product bundles 'ansi-regex', 'ansi-styles', 'is-fullwidth-code-point', 
'string-width' and 'wrap-ansi' from the above files.
+  These packages are available under the MIT License:
     MIT License
 
-    Copyright (c) Roy Ivy III <[email protected]>
-    Copyright (c) Sindre Sorhus <[email protected]> (sindresorhus.com)
+    Copyright (c) Sindre Sorhus <[email protected]> 
(https://sindresorhus.com)
+
+    Permission is hereby granted, free of charge, to any person obtaining a 
copy of this software and associated documentation files (the "Software"), to 
deal in the Software without restriction, including without limitation the 
rights to use, copy, modify, merge, publish, distribute, sublicense, and/or 
sell copies of the Software, and to permit persons to whom the Software is 
furnished to do so, subject to the following conditions:
+
+    The above copyright notice and this permission notice shall be included in 
all copies or substantial portions of the Software.
+
+    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE 
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER 
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, 
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE 
SOFTWARE.
+
+- 'arg' in extension/dist/ext/extension.js
+       This product bundles 'arg' from the above files.

Review Comment:
   It's not obvious in this diff, but these files mix tabs and spaces in some 
places. It might be worth converting them to spaces just so we're consistent.



##########
build/package/LICENSE:
##########
@@ -924,75 +844,50 @@ conditions of the following licenses.
     OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
     WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-    ====
-
-    Copyright and related rights for sample code are waived via CC0. Sample
-    code is defined as all source code displayed within the prose of the
-    documentation.
-
-    CC0: http://creativecommons.org/publicdomain/zero/1.0/
-
-    ====
-
-    Files located in the node_modules and vendor directories are externally
-    maintained libraries used by this software which have their own
-    licenses; we recommend you read them, as their terms may differ from the
-    terms above.
-
-- 'prettier' in extension/dist/ext/extension.js
-  This product bundles 'prettier' from the above files.
-  This package is available under the MIT License:
-    Copyright © James Long and contributors
-
-    Permission is hereby granted, free of charge, to any person obtaining a 
copy of this software and associated documentation files (the "Software"), to 
deal in the Software without restriction, including without limitation the 
rights to use, copy, modify, merge, publish, distribute, sublicense, and/or 
sell copies of the Software, and to permit persons to whom the Software is 
furnished to do so, subject to the following conditions:
-
-    The above copyright notice and this permission notice shall be included in 
all copies or substantial portions of the Software.
-
-    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE 
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER 
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, 
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE 
SOFTWARE.
+- 'v8-compile-cache-lib' in extension/dist/ext/extension.js
+       This product bundles 'v8-compile-cache-lib' from the above files.
+       This package is available under the MIT LICENSE:
 
-- 'require-directory' in extension/dist/ext/extension.js
-  This product bundles 'require-directory' from the above files.
-  This package is available under the MIT License:
     The MIT License (MIT)
+    
+    Copyright (c) 2019 Andres Suarez
+    
+    Permission is hereby granted, free of charge, to any person obtaining a 
copy
+    of this software and associated documentation files (the "Software"), to 
deal
+    in the Software without restriction, including without limitation the 
rights
+    to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+    copies of the Software, and to permit persons to whom the Software is
+    furnished to do so, subject to the following conditions:
+    
+    The above copyright notice and this permission notice shall be included in 
all
+    copies or substantial portions of the Software.
+    
+    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 
FROM,
+    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN 
THE
+    SOFTWARE.
 
-    Copyright (c) 2011 Troy Goode <[email protected]>
-
-    Permission is hereby granted, free of charge, to any person obtaining a
-    copy of this software and associated documentation files (the
-    "Software"), to deal in the Software without restriction, including
-    without limitation the rights to use, copy, modify, merge, publish,
-    distribute, sublicense, and/or sell copies of the Software, and to
-    permit persons to whom the Software is furnished to do so, subject to
-    the following conditions:
-
-    The above copyright notice and this permission notice shall be included
-    in all copies or substantial portions of the Software.
-
-    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
-    OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-    MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
-    IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
-    CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
-    TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
-    SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-- 'yargs' in extension/dist/ext/extension.js
-  This product bundles 'yargs' from the above files.
-  This package is available under the MIT License:
-    MIT License
-
-    Copyright 2010 James Halliday ([email protected]); Modified work Copyright 
2014 Contributors ([email protected])
+- 'yargs-unparser' in extension/dist/ext/extension.js

Review Comment:
   I don't see `yargs-unparser` in the list of dependencies. I only see 
`yargs-parser` (listed above) and `yargs`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to