mike-mcgann commented on code in PR #977:
URL: https://github.com/apache/daffodil/pull/977#discussion_r1126723370
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/dsom/SDE.scala:
##########
@@ -120,20 +120,14 @@ class SchemaDefinitionWarning(
args: _*,
) {
- def this(sc: SchemaFileLocation, kind: String, args: Any*) =
- this(None, Some(sc), None, kind, args: _*)
+ def this(w: WarnID, sc: SchemaFileLocation, kind: String, args: Any*) =
+ this(w, Some(sc), None, kind, args: _*)
override def isError = false
def modeName = "Schema Definition"
- override def toString = warnID match {
- case Some(id) =>
- super.toString + "\n" +
- s"To suppress this warning, add '${id}' to the " +
- "daf:suppressSchemaDefinitionWarnings element of a Daffodil
defineConfig " +
- "used when processing"
- case None => super.toString
- }
+ override def getMessage = super.getMessage + s" (id: ${warnID})"
Review Comment:
Ok, I updated it to that which doesn't require opening private definitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]