stevedlawrence commented on code in PR #981:
URL: https://github.com/apache/daffodil/pull/981#discussion_r1129835842
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/primitives/PrimitivesDelimiters.scala:
##########
@@ -68,15 +69,33 @@ abstract class DelimiterText(
case _ => false
}
+ // When the value is known to be empty, is this delimiter required to
+ // be present according to the emptyValueDelimiterPolicy
+ private val requiredOnEmptyValue = e match {
+ case elemB: ElementBase =>
elemB.isDelimiterRequiredWhenEmpty(delimiterType)
+ case _ => true
+ }
Review Comment:
With the above suggestion, this just becomes a parameter passed into the
`DelimiterText` constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
