stevedlawrence commented on code in PR #982:
URL: https://github.com/apache/daffodil/pull/982#discussion_r1129865660
##########
daffodil-test/src/test/resources/org/apache/daffodil/section13/text_number_props/TextNumberProps.tdml:
##########
@@ -4039,16 +4081,13 @@
<tdml:documentPart
type="text"><![CDATA[NOTANUMBER]]]></tdml:documentPart>
</tdml:document>
- <tdml:warnings>
- <tdml:warning>DFDL property was ignored</tdml:warning>
- <tdml:warning>textStandardNaNRep</tdml:warning>
- </tdml:warnings>
+ <tdml:warnings />
Review Comment:
The empty `tdml:warnings` explicitly says "there should be no warnings",
whereas not having a `tdml:warnings` element just says "we don't care if there
are warnings or not". The idea with changing it like this was that the test
used to expect a warning saying this property was ignored, but the property is
now used so I wanted to make sure it's not ignored and there's no warning. We
do get an error mentioning "NaN" so that should be enough to make it clear the
property is used, but I wanted to still keep the intention of the test
regarding warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
