Shanedell commented on issue #471: URL: https://github.com/apache/daffodil-vscode/issues/471#issuecomment-1473725967
I believe when initially setting things up, we made it so that if the folder for the specific version of the debugger and daffodil being used already exists we wouldn't recreate it. I agree that when doing updates to the debugger this would cause issues. We can either: - 1. Always extract the debugger. - 2. Create a setting that lets the extension know it should re-extract the debugger. - 3. Have logic in the code that tries to figure out when the debugger is running through a VSIX or locally and based upon decides if should extract/re-extract or not. Basically if VSIX -> don't extract if folder present, if locally -> always extract. There is also a conversation to be had that we could bundle the extracted debugger package instead of the zip. This should allow us to have any newly updated debugger unzipped at the same location of the zip and the extension will know where to grab it, this should also work when dealing with running from an VSIX file. This would also simplify code so that we don't need to be doing extracts, copies, etc of the debugger to different locations. Another benefit is when running a new version of the debugger either locally or through VSIX or in tests, the first launch will happen much quicker since you would no longer be waiting for checks if the folder already exists as well as the extraction of the zip to happen. I personally think we should move away from bundling and having the cod extract the zipped up debugger, and instead bundle the extracted debugger package. @mbeckerle @stevedlawrence would bundling the unzipped debugger go against any Apache workflow norms or standards? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
