arosien commented on code in PR #495:
URL: https://github.com/apache/daffodil-vscode/pull/495#discussion_r1140704217
##########
src/adapter/activateDaffodilDebug.ts:
##########
@@ -406,6 +406,10 @@ class DaffodilConfigurationProvider
config = getConfig('Launch', 'launch', 'dfdl')
}
+ if (!config.debugServer) {
Review Comment:
> I need to try this, as this doesn't look like it will do anything given
code like
>
>
https://github.com/apache/daffodil-vscode/blob/main/src/daffodilDebugger.ts#LL211-L215
>
> which doesn't even use the `serverPort`.
This code is a different latent bug which ignores the numeric `debugServer`
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
