Shanedell commented on code in PR #510:
URL: https://github.com/apache/daffodil-vscode/pull/510#discussion_r1144073985
##########
src/omega_edit/client.ts:
##########
@@ -142,8 +142,7 @@ export function activate(ctx: vscode.ExtensionContext) {
'extension.data.edit',
async (
startServ: boolean = true,
- port: number | undefined = undefined,
- fileToEdit: string = ''
Review Comment:
You will need to revert all these changes that deal with `fileToEdit`.
The code involving `fileToEdit` is essential for the API to function
properly for the tests. With this change during the tests when the data editor
is initially opened it will prompt to select a file which is not the desired
behavior during testing. The test still currently passes since it just checks
the webview is opened, which it is behind the file picking prompt. In future
tests for the data editor we will want to use the content that is inside of the
data editor. To do this we need to be able to specify the file we wish to edit
so that the editor will contain content and not get stuck on a file prompt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
