Shanedell commented on code in PR #534:
URL: https://github.com/apache/daffodil-vscode/pull/534#discussion_r1151003450
##########
src/omega_edit/utils.ts:
##########
@@ -94,7 +94,7 @@ export function logicalDisplay(
bytes: ArrayBuffer,
bytesPerRow: number
): string {
- const undefinedCharStandIn = '�'
+ const undefinedCharStandIn = '░'
Review Comment:
@stricklandrbls Can we instead change this variable to be `const
undefinedCharCodeStandIn = 9617`? Then when you go to use it do
`String.fromCharCode(undefinedCharCodeStandIn)`? I was able to get this char
code value by doing `console.log('░'.charCodeAt(0))` in a nodejs shell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
