arosien commented on code in PR #582:
URL: https://github.com/apache/daffodil-vscode/pull/582#discussion_r1170057583
##########
src/dataEdit/client.ts:
##########
@@ -80,9 +80,29 @@ function getPidFile(serverPort: number) {
async function getOmegaEditPort() {
if (omegaEditPort === 0) {
- omegaEditPort = vscode.workspace
- .getConfiguration('dataEditor')
- .get<number>('omegaEditPort', DEFAULT_OMEGA_EDIT_PORT)
+ /**
Review Comment:
(the json configuration is using the literal property
`dataEditor.omegaEditPort` (a property with a name that has a period in it), so
this code doesn't work. I would recommend changing the configuration property
to be hierarchical (no period) so that the current code will work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
