michael-hoke commented on PR #305: URL: https://github.com/apache/daffodil-vscode/pull/305#issuecomment-1582816571
Thanks, that sounds like it covers us for almost everything. We do have one file that has what I would consider to be major changes - I'd estimate it on the order of 50/50 with code that we pulled from the extension versus code we wrote ourselves, and, if it changes anything, there's probably more code in the original file that we didn't use than code we did use. Their file: https://github.com/DeltaXML/vscode-xslt-tokenizer/blob/master/src/extension.ts Our file: https://github.com/michael-hoke/daffodil-vscode-fork/blob/daffodil-vscode-semantic-highlighting/src/language/semantics/dfdlExt.ts That is also assuming that removing significant portions of code isn't going to be considered a major change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
