shanedell commented on code in PR #664:
URL: https://github.com/apache/daffodil-vscode/pull/664#discussion_r1232647837


##########
src/launchWizard/launchWizard.js:
##########
@@ -18,12 +18,62 @@
 // Retrieve vscode api - Doing this multiple times causes issues with the 
scripts
 const vscode = acquireVsCodeApi()
 
+// Function to get config index
+function getConfigIndex() {
+  var configSelectionBox = document.getElementById('configSelected')
+  var configSelectedValue =
+    configSelectionBox.options[configSelectionBox.selectedIndex].value
+
+  if (configSelectedValue === 'New Config') {
+    document.getElementById('nameLabel').style =
+      'margin-top: 10px; visibility: visible;'
+  } else {
+    document.getElementById('nameLabel').style = 'visibility: hidden;'
+  }
+
+  return configSelectedValue === 'New Config'
+    ? -1
+    : configSelectionBox.selectedIndex
+}
+
+// Function get daffodil debug classpath string
+function getDaffodilDebugClasspathString() {

Review Comment:
   @nlewis05 you should be able to update this function to just be this
   
   ```ts
   // Function get daffodil debug classpath string
   function getDaffodilDebugClasspathString() {
     let childNodes = document.getElementById(
       'daffodilDebugClasspathTable'
     ).childNodes
   
     return Array.from(childNodes)
       .map(
         (childNode) =>
           childNode.textContent
             .replace(/\B\s+|\s+\B/g, '') // remove any un-needed whitespace. 
will not remove spaces between characters
             .replace('-', '') // remove initial - in front of every item
       )
       .filter((cp) => cp != '')
       .join(':')
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to