mbeckerle commented on code in PR #1047:
URL: https://github.com/apache/daffodil/pull/1047#discussion_r1261191106
##########
daffodil-tdml-processor/src/main/scala/org/apache/daffodil/processor/tdml/DaffodilTDMLDFDLProcessor.scala:
##########
@@ -190,8 +190,8 @@ class DaffodilTDMLDFDLProcessor private (private var dp:
DataProcessor)
}
override def withDebugger(db: AnyRef): DaffodilTDMLDFDLProcessor = {
- Assert.usage(dp ne null)
- val d = dp.asInstanceOf[Debugger]
+ Assert.usage(db ne null)
+ val d = db.asInstanceOf[Debugger]
Review Comment:
Note that code cov says this wasn't a bug, because it's _not called_.
##########
daffodil-tdml-processor/src/main/scala/org/apache/daffodil/processor/tdml/DaffodilTDMLDFDLProcessor.scala:
##########
@@ -190,8 +190,8 @@ class DaffodilTDMLDFDLProcessor private (private var dp:
DataProcessor)
}
override def withDebugger(db: AnyRef): DaffodilTDMLDFDLProcessor = {
- Assert.usage(dp ne null)
- val d = dp.asInstanceOf[Debugger]
+ Assert.usage(db ne null)
+ val d = db.asInstanceOf[Debugger]
Review Comment:
Wow. What a bug.
We should disallow use of tiny value names like dp and db and spell things
out a little more I think.
db here is a parameter name. That one should definitely be spelled out as
'debugger'.
##########
daffodil-cli/src/test/scala/org/apache/daffodil/cli/cliTest/TestCLItdml.scala:
##########
@@ -110,6 +110,16 @@ class TestCLItdml {
}(ExitCode.Success)
}
+ @Test def test_CLI_Tdml_Trace_singleTest(): Unit = {
+ val tdml = path(
+
"daffodil-test/src/test/resources/org/apache/daffodil/section06/entities/Entities.tdml",
+ )
+
+ runCLI(args"-t test $tdml byte_entities_6_08") { cli =>
+ cli.expect("[Pass] byte_entities_6_08")
Review Comment:
Please add comments here about what you'd like to test, but how expect isn't
letting you do so.
Also add a JIRA ticket about that issue and reference it from the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
