scholarsmate commented on code in PR #702:
URL: https://github.com/apache/daffodil-vscode/pull/702#discussion_r1262816851
##########
package.json:
##########
@@ -633,46 +627,23 @@
"description": "Editor server default port",
"default": 9000
},
- "dataEditorLogFile": {
- "type": "string",
- "description": "Path to log file for data editor",
- "default": "${workspaceFolder}/dataEditor-${omegaEditPort}.log"
- },
- "dataEditorLogLevel": {
- "type": "string",
- "description": "Log level for data editor",
- "enum": [
- "error",
- "warn",
- "info",
- "debug",
- "trace"
- ],
- "default": "info"
- },
- "dfdlDebuggerLogLevel": {
- "type": "string",
- "description": "Log level for debugger",
- "enum": [
- "ALL",
- "DEBUG",
- "ERROR",
- "INFO",
- "OFF",
- "TRACE",
- "WARN"
- ],
- "default": "INFO"
- },
- "dfdlDebuggerLogFile": {
- "type": "string",
- "description": "Path to log file for debugger",
- "default": "/tmp/daffodil-debugger.log"
+ "dataEditor": {
+ "type": "object",
+ "description": "Configuration for Data Editor. Settings are port,
logFile and logLevel",
+ "default": {
+ "port": 9000,
+ "logFile": "${workspaceFolder}/dataEditor-${omegaEditPort}.log",
+ "logLevel": "info"
+ }
Review Comment:
I prefer the way this is done in the `dfdlDebugger` section, so make this:
```
"default": {
"port": 9000,
"logging": {
"file": "${workspaceFolder}/dataEditor-${omegaEditPort}.log",
"level": "INFO"
}
}
```
So we don't have 2 different ways to do the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
