arosien opened a new issue, #713:
URL: https://github.com/apache/daffodil-vscode/issues/713

   Our configuration contribution of the extension, which holds extension 
property settings, doesn't namespace the property names, which seems [to go 
against 
recommendations](https://code.visualstudio.com/api/references/contribution-points#contributes.configuration).
 At runtime all settings are stored in a shared property map, so we could be 
accidentally clobbering properties by not having a namespace.
   
   We can also load only our settings via:
   ```diff
   - const defaultConf = vscode.workspace.getConfiguration()
   + const defaultConf = vscode.workspace.getConfiguration('daffodil')
   ```
   
   At the same time, we seem to use the pseudo-namespace `dfdl` in places, and 
perhaps we should use the more readable `daffodil`. But also, the extension 
itself uses the id `apache-daffodil-vscode`, so perhaps that should be the 
namespace we use in all configuration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to