michael-hoke commented on code in PR #706:
URL: https://github.com/apache/daffodil-vscode/pull/706#discussion_r1270775800
##########
src/adapter/activateDaffodilDebug.ts:
##########
@@ -52,7 +52,18 @@ async function getFile(fileRequested, label, title) {
})
.then((fileUri) => {
if (fileUri && fileUri[0]) {
- return fileUri[0].fsPath
+ let path = fileUri[0].fsPath
+
+ if (
+ process.platform === 'win32' &&
+ path.charCodeAt(0) > 97 &&
+ path.charCodeAt(0) <= 122 &&
+ path.charAt(1) === ':'
Review Comment:
Wouldn't that open us up to a NullPointerException? If fileUri[0] is null,
it'll get caught by the if, and this code won't be hit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
