olabusayoT commented on code in PR #1058:
URL: https://github.com/apache/daffodil/pull/1058#discussion_r1275371006
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/DataProcessor.scala:
##########
@@ -340,8 +340,10 @@ class DataProcessor(
* runtime. Instead we deal with success and failure statuses.
*/
def parse(input: InputSourceDataInputStream, output: InfosetOutputter):
DFDL.ParseResult = {
- Assert.usage(!this.isError)
-
+ Assert.argCheck(
+ !this.isError,
+ s"Must check isError before calling DataProcessor parse.
${this.getDiagnostics.mkString}",
Review Comment:
The diagnostics were included based on this comment:
https://github.com/apache/daffodil/pull/1058#pullrequestreview-1541309384,
should I disregard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
