stevedlawrence commented on code in PR #1058:
URL: https://github.com/apache/daffodil/pull/1058#discussion_r1276184653
##########
daffodil-lib/src/main/scala/org/apache/daffodil/lib/exceptions/Assert.scala:
##########
@@ -91,6 +91,12 @@ object Assert extends Assert {
def usage(testAbortsIfFalse: Boolean, message: String): Unit = macro
AssertMacros.usageMacro2
def usage(testAbortsIfFalse: Boolean): Unit = macro AssertMacros.usageMacro1
+ /**
+ * Test for the validity of the arguments of the API functions
+ */
+ def argCheck(testThrowsIfFalse: Boolean, message: String): Unit =
Review Comment:
Yeah, an argCheck function probably wants to either call abort or throw an
IllegalArgumentException. But our uses aren't really about checking args, so
I'd suggest we rename it. See other comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
