stevedlawrence commented on code in PR #734: URL: https://github.com/apache/daffodil-vscode/pull/734#discussion_r1286021678
########## NOTICE: ########## @@ -7,3 +7,10 @@ The Apache Software Foundation (http://www.apache.org/). Based on source code originally developed by - Concurrent Technologies Corporation (https://www.ctc.com/) - Nteligen LLC (https://www.nteligen.com/) + +The following NOTICE information applies to binary components distributed with this project: + +- src/svelte/src/resources/icons/material-icons.woff2 + This product bundles 'material-icons' from the above files. + This package is available under the Apache License v2 without a NOTICE: + Repository at: https://github.com/google/material-design-icons Review Comment: If a ALv2 licensed file does not include a NOTICE file then ti should not be mentioned in the NOTICE file. I think this project has been using a NONOTICE file to keep track of those so there is some documentation of it. ########## LICENSE: ########## @@ -360,7 +360,6 @@ conditions of the following licenses. - src/adapter/activateDaffodilDebug.ts - src/adapter/daffodilDebug.ts - src/adapter/daffodilRuntime.ts -- src/adapter/debugAdapter.ts - src/adapter/extension.ts Review Comment: This above changes should really be part of a separate pull request fixing licensing issues. ########## LICENSE: ########## @@ -456,3 +455,198 @@ conditions of the following licenses. LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + +- src/svelte/src/resources/fonts/RedHatMono-Regular.woff2 + This product bundles the above files from the 'RedHatFont' repo. (https://github.com/RedHatOfficial/RedHatFont) + These files are available under the SIL Open Font License, Version 1.1: Review Comment: ASF considers the SIL Open Font License as weak copyleft, ASF says this about that: > You may include software under the following licenses in binary form within an Apache product if you label the inclusion appropriately (see above) <sub>[[source](https://www.apache.org/legal/resolved.html#weak-copyleft-licenses)]</sub> We have interpreted "label the inclusion appropriately" as meaning to as adding a line to the license section in our README. We should do that for boh this font and the other SIL font. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
