stricklandrbls commented on code in PR #758:
URL: https://github.com/apache/daffodil-vscode/pull/758#discussion_r1290141052
##########
src/dataEditor/dataEditorClient.ts:
##########
@@ -385,7 +385,7 @@ export class DataEditorClient implements vscode.Disposable {
}
break
- case MessageCommand.commit:
+ case MessageCommand.apply:
Review Comment:
Given that we're going to change the term, I think "Apply" would suffice for
the button label but maybe we should make the source code a little more verbose?
`MessageCommand.applyEdits` or `applyChangesToViewport`
I just wonder if we'll end up having to change the term in the source if we
choose a generic `apply`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
