scholarsmate commented on code in PR #778:
URL: https://github.com/apache/daffodil-vscode/pull/778#discussion_r1291721690
##########
src/infoset.ts:
##########
@@ -25,11 +25,12 @@ import {
ensureFile,
tmpFile,
} from './utils'
+import * as JSONC from 'jsonc-parser'
// Function to display an infomation message that the infoset file has been
created
// If the user wishes to open the file then they may click the 'Open' button
async function openInfosetFilePrompt() {
- let config = JSON.parse(JSON.stringify(getCurrentConfig()))
+ let config = JSONC.parse(JSON.stringify(getCurrentConfig()))
Review Comment:
I don't see the benefit of using JSONC in cases where you're parsing the
output of `JSON.stringify` because comments (if there were any) aren't going to
survive that operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
