stricklandrbls commented on code in PR #841:
URL: https://github.com/apache/daffodil-vscode/pull/841#discussion_r1327756565
##########
src/dataEditor/dataEditorClient.ts:
##########
@@ -94,8 +96,19 @@ const OMEGA_EDIT_MIN_PORT: number = 1024
// file-scoped types
//
*****************************************************************************
+class ServerInfo implements IServerInfo {
+ serverHostname: string = 'unknown' // hostname
Review Comment:
I'd have to look more at the flow of data for this particular instance but
just in general I like the idea of strict and defined types over `string` or
`number`. There are also cases where you can "type define" yourself into a
corner and this might be one of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
