shanedell commented on code in PR #874: URL: https://github.com/apache/daffodil-vscode/pull/874#discussion_r1353097384
########## src/language/providers/intellisense/attributeHoverItems.ts: ########## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundation (ASF under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License Version 2.0 + * (the "License"; you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing software + * distributed under the License is distributed on an "AS IS" BASIS + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +// prettier-ignore + +export function attributeHoverValues(attributeName: string): string { + let hoverValue: string = '' + switch (attributeName) { + case 'name': + hoverValue = 'specify name' + break + case 'ref': + hoverValue = 'Specifies the name of an element in this schema' + break + case 'minOccurs': + hoverValue = 'Minimum number of times element will occur' + break + case 'maxOccurs': + hoverValue = 'Maximum number of times element will occur' + break + case 'dfdl:occursCount': + hoverValue = 'dfdl:occursCount property takes an expression which commonly looks in the Infoset via an expression to obtain the count from another element.' + break Review Comment: @rthomas320 Don't run `yarn prettier fix`, run `yarn lint:fix`. You may be running a global version of `prettier` instead of the one for `daffodil-vscode` specifically. I also think `yarn prettier fix` is not a command I believe if you want to run the fix manually instead of using `yarn lint:fix` it would be `yarn prettier src -w`, `src` is the directory to look at and `-w` tells prettier to fix the issues it finds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
