tuxji commented on code in PR #1098: URL: https://github.com/apache/daffodil/pull/1098#discussion_r1367992578
########## daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/SchemaDocument.scala: ########## @@ -212,6 +212,8 @@ final class SchemaDocument private (xmlSDoc: XMLSchemaDocument) final override lazy val optLexicalParent = Some(xmlSDoc) final override lazy val optXMLSchemaDocument = Some(xmlSDoc) + final lazy val version = (xml \ "@version").text Review Comment: Alas, I merged the PR before I checked my emails and saw your reply, It's too late to put the change into the PR now, but let's keep it in mind for another PR: ```scala final lazy val optVersion = (xml \ "@version").headOption.map(_.text) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
