[
https://issues.apache.org/jira/browse/DAFFODIL-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Thompson closed DAFFODIL-2852.
-----------------------------------
Verified the specified commit (commit f3fb555c98aa3cfe24270f38b579b03316cc8ad0)
is included in the latest pull from the daffodil repository.
Verified, via review, changes identified in the commit comment were
implemented.
Verified the affected daffodil subproject sbt test suites executed
successfully, including the added test.
Verified the nightly test schemas compile and save successfully with no
unexpected failures.
Verified the nightly test suite executes successfully with no unexpected
failures.
Verified a slight to significant performance increases on many of the nightly
test formats.
> VariableMap copies during suspensions cause performance degredation
> -------------------------------------------------------------------
>
> Key: DAFFODIL-2852
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2852
> Project: Daffodil
> Issue Type: Bug
> Components: Back End, Unparsing
> Reporter: Steve Lawrence
> Assignee: Steve Lawrence
> Priority: Major
> Fix For: 3.6.0
>
>
> When a suspension is created when unparsing, we create a copy of the
> VariableMap so that future newVariableInstances do not affect the supension.
> The current VariableMap internals uses a Map of ArrayBuffers, both of which
> are fairly expensive to copy, with the overhead showing up heavily when
> profiling. We should change the VariableMap internals to use a data structure
> that allows fast copies, while still maintaining constant time lookups.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
