shanedell commented on code in PR #917:
URL: https://github.com/apache/daffodil-vscode/pull/917#discussion_r1424665346
##########
package.json:
##########
@@ -41,6 +41,7 @@
"package": "run-func build/yarn-scripts.ts package && yarn --cwd
dist/package install && yarn --cwd dist/package vsce package --out ../../",
"pretest": "yarn compile && yarn webpack",
"test": "sbt test && node ./out/tests/runTest.js",
Review Comment:
I would say that either before or after `node ./out/tests/runTest.js` you
want to run the svelte tests. So either,
```json
"test": "sbt test && yarn test:svelte && node ./out/tests/runTest.js",
```
or
```json
"test": "sbt test && node ./out/tests/runTest.js && yarn test:svelte",
```
I personally prefer the first option but either way is fine with me also.
Once that is updated I think this is good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
