shanedell commented on code in PR #926:
URL: https://github.com/apache/daffodil-vscode/pull/926#discussion_r1440910028


##########
package.json:
##########
@@ -269,13 +264,6 @@
         "category": "Daffodil Debug",
         "enablement": "inDebugMode"
       },
-      {
-        "command": "hexview.display",
-        "title": "Display the hex view",
-        "category": "Daffodil Debug",
-        "enablement": "inDebugMode",
-        "icon": "$(file-binary)"
-      },

Review Comment:
   I think this should stay in but update it to use `data.edit` instead of 
`hexview.display` and update the title. It would still be nice to click this 
icon and have it just open the data editor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to