mbeckerle commented on code in PR #929:
URL: https://github.com/apache/daffodil-vscode/pull/929#discussion_r1443377147


##########
src/launchWizard/launchWizard.js:
##########
@@ -64,7 +64,7 @@ function getConfigValues() {
     'openInfosetDiffView'
   ).checked
   const openInfosetView = document.getElementById('openInfosetView').checked
-  const program = document.getElementById('program').value
+  const schema = document.getElementById('schema').value

Review Comment:
   Hmmm. Can you help me understand why we have both a launchWizard.js and a 
launchWizard.ts file? I thought ts was the VSCode typed flavor of javascript, 
and that its use subsumed javascript inside VSCode. 
   
   My understanding is obviously superficial. Can you help me understand why we 
need both in this situation? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to