shanedell commented on code in PR #927:
URL: https://github.com/apache/daffodil-vscode/pull/927#discussion_r1443390534
##########
src/utils.ts:
##########
@@ -79,6 +80,30 @@ export async function onDebugStartDisplay(viewsToCheck:
string[]) {
})
}
+function checkInfosetFileExtension(
+ infosetOutput: InfosetOutput,
+ infosetFormat: string
+) {
+ // If the infoset file path doesn't end with the infoset output format,
update to end with infoset output format.
+ if (!infosetOutput.path.endsWith(`.${infosetFormat}`)) {
Review Comment:
So this is the only place I believe is filtering off a regex. Other places
are using `.exec` and some use `.test`. These perform different as `exec` give
you a result and `test` just tells you true or false. I mean we could make
wrappers around these but not sure how useful that is as you would just be
calling `WrapperFunction` each time instead of `exec` or `test`. We could also
make a call back function but that would also kind of just achieve the same
thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
