stevedlawrence commented on PR #1134: URL: https://github.com/apache/daffodil/pull/1134#issuecomment-1882984941
`parsingPadChar` comes from here: https://github.com/apache/daffodil/blob/main/daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/primitives/Padded.scala#L48-L52 If `textTrimKind` is `"none"`, then `parsingPadChar` is `None` and the justification is forced to `None`, so we'll never call `remove*Padding` and hit the `isEmpty` true block. If `textTrimKind` is not `"none"`, then we require a pad character, so whatever `remove*Padding` function is called (based on the justification), we will have a `parsingPadChar` defined and hit the `isEmpty` false block. So it is reasonable to assert here--it's not possible for `parsingPadChar` to be empty if a `remove*Padding` function is called. I'll make the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
