shanedell commented on PR #926: URL: https://github.com/apache/daffodil-vscode/pull/926#issuecomment-1884080861
Like @hdalsania mentiones I believe that code in here is good. I honestly think there maybe is a bug on the omega-edit side that is causing the issues. Mostly an issue of it not killing the server in some instances for kind of unknown reasons. So in my option is that this gets merged in once @stricklandrbls gets another binding +1 and then we can take a better look at the omega-edit side and see if we can figure out whats going wrong with killing the server. I believe the killing of the server has always been a headache especially in windows because I think the way its done in windows may not always kill it. But then in Mac and Linux I think it does pretty good for the most part other than if you stop debugging the extension before exiting the Data Editor I think the server doesn't get killed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
