stevedlawrence commented on PR #1146: URL: https://github.com/apache/daffodil/pull/1146#issuecomment-1894256227
My first commit allowed a scan to run on PR, since the documentation says it's possible. The documentation is correct, however, it leaves out that due to limitations in GitHub actions it will not work from PR's from a forked repo. This is because github actions does not pass secrets to workflows originating from a forked repository to prevent leaking secret. But this means the SONAR_TOKEN secret that is required cannot be passed to the scan. So until SonarCloud comes up with alternative that does not require a secret token, we cannot allow scans on PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
