tuxji commented on code in PR #10: URL: https://github.com/apache/daffodil-sbt/pull/10#discussion_r1463646027
########## src/sbt-test/sbt-daffodil/common-settings-01/test.script: ########## @@ -0,0 +1,20 @@ +## Licensed to the Apache Software Foundation (ASF) under one +## or more contributor license agreements. See the NOTICE file +## distributed with this work for additional information +## regarding copyright ownership. The ASF licenses this file +## to you under the Apache License, Version 2.0 (the +## "License"); you may not use this file except in compliance +## with the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, +## software distributed under the License is distributed on an +## "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +## KIND, either express or implied. See the License for the +## specific language governing permissions and limitations +## under the License. +## + +> compile +> test Review Comment: When and how is test.script called? ########## src/main/scala/org/apache/daffodil/DaffodilPlugin.scala: ########## @@ -57,11 +60,55 @@ object DaffodilPlugin extends AutoPlugin { } override lazy val projectSettings: Seq[Setting[_]] = Seq( + /** + * Default Daffodil version + */ + daffodilVersion := "3.6.0", + + /** + * Add Daffodil and version specific test dependencies + */ + libraryDependencies ++= { + // Seq of 2-tuples, where each tuple is a Seq of version specifiers and a list of + // dependencies to add if the daffodilVersion matches all of those specifiers. If the + // version specifier Seq is empty, the associated dependencies are added regardless of + // Daffodil version + val versionedDeps = Seq( + // always add Daffodil and junit test dependencies + Nil -> Seq( + "org.apache.daffodil" %% "daffodil-tdml-processor" % daffodilVersion.value % "test", + "junit" % "junit" % "4.13.2" % "test", + "com.github.sbt" % "junit-interface" % "0.13.2" % "test", + ), + // Add log4j with older versions of Daffodil to silence warnings about missing loggers + Seq(">=3.2.0", "<=3.4.0") -> Seq( + "org.apache.logging.log4j" % "log4j-core" % "2.20.0" % "test", + ), + ) Review Comment: Agreed, should we add the scripted test in this PR or? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
