stevedlawrence commented on code in PR #13: URL: https://github.com/apache/daffodil-sbt/pull/13#discussion_r1465108638
########## README.md: ########## @@ -94,6 +94,23 @@ If used, one may want to use the first value of this setting to configure daffodilVersion := daffodilPackageBinVersions.value.head ``` +## Layers and User Defined Functions + +If your schema project builds a Daffodil layer or user defined function, then +set the `daffodilBuildsLayer` or `daffodilBuildsUDF` setting to true, +respectively. For example: + +```scala +daffodilBuildsLayer := true + +daffodilBuildsUDF := true +``` + +Setting either of these values to true adds additional dependencies needed to +build the component. Note that this also sets the SBT `crossPaths` setting to +`true`, which causes the scala version to be included in that jar file name +since layer and UDF jars are specific to the scala version used to build them. Review Comment: Yeah, I think you're right. Maybe instead of using these settings we should just check if `Compile / sources` contains any files that end in *.scala. If any exist then we set `crossPaths` to true. This has the advantage that if a schema project has any scala source files at all, even if they aren't using UDFs or layers, that they get the correct _2.12 since they do use scala. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
