tuxji commented on code in PR #12: URL: https://github.com/apache/daffodil-sbt/pull/12#discussion_r1465138835
########## src/sbt-test/sbt-daffodil/flat-layout-01/build.sbt: ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +version := "0.1" + +name := "test" + +organization := "com.example" Review Comment: Are these values for version, name, and organization appropriate to use? ########## src/sbt-test/sbt-daffodil/flat-layout-01/test/test.scala: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.example + +import org.junit.Test +import org.apache.daffodil.tdml.Runner +import org.junit.AfterClass + +object TestExample { + lazy val runner = Runner("/", "test.tdml") + + @AfterClass def shutdown: Unit = { runner.reset } +} + +class TestExample { + import TestExample._ + + @Test def test_test01() { runner.runOneTest("test01") } +} Review Comment: I remember the wish list for the sbt-daffodil plugin includes making these Scala files unnecessary (as long as IDEs are given some way to debug individual tests through sbt). I think that feature would be very helpful :-). An idea might be to automatically generate this kind of file in a `test-managed` directory during `sbt compile` (or `sbt Test/compile` or `sbt test`). Then we still can open this kind of Scala file in our IDEs to debug individual tests within the debugger, but our responsibility for creating and updating these files is handed over to the sbt plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
