shanedell commented on code in PR #952:
URL: https://github.com/apache/daffodil-vscode/pull/952#discussion_r1470389220
##########
debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:
##########
@@ -399,8 +399,10 @@ object Parse {
// arguments: Launch config
def parseRootName(arguments: JsonObject) =
Right(
-
Option(arguments.getAsJsonObject("schema").getAsJsonPrimitive("rootName"))
- .map(_.getAsString())
+ arguments.getAsJsonObject("schema").get("rootName") match {
Review Comment:
This change was needed for both `parseRootName` and `parseRootNamespace`.
Without it, passing `null` from the TS to the Scala would cause an error:
```bash
class com.google.gson.JsonNull cannot be cast to class
com.google.gson.JsonPrimitive
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
