stevedlawrence commented on code in PR #1137:
URL: https://github.com/apache/daffodil/pull/1137#discussion_r1481629056
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dpath/Expression.scala:
##########
@@ -2295,6 +2332,20 @@ abstract class FunctionCallBase(
res
}
+ protected def checkArgArrayOrOptional(): Unit = {
Review Comment:
I took another scan at this, and it looks like `isTypeCorrect` (which
already calls isPathToOneWholeArray) is never actually used. I suggest we just
delete this val and the couple of references to it, and then move your
`checkArgArrayOrOptional` function to `FunctionCallArrayBase`. It can then use
arrPath (instead of expression.head) to verify that is goes to a whole array.
And then update implementations of FunctionCallArrayBase to call this function,
since they should all go to a whole array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
