stevedlawrence commented on PR #1162: URL: https://github.com/apache/daffodil/pull/1162#issuecomment-1961531105
SBT updated to a newer version of jline, which fixed our jline incompatibility issues. Our tests to fix this detected this, but SBT didn't actually fix the issue permanently--if we update to a newer version of jline that is incompatible the issue could come back. Think we have two options: 1) Keep everything the same, but remove/comment out the `test_CLI_Debugger_sbt_jline_broken` test. We will no longer have a test to detect if SBT actually fixes the underlying issue. But our other CLI debugger tests will still fork and should never be affected by an SBT jline incompatibility. But because they fork, they may be a bit slower to run. 2) Move our debugger tests back to the `daffodil-cli` project and remove the forking aspect, reverting to what we had before the incompatibility. Tests will likely run a bit faster, but a future jline update that is incompatible with the version SBT ships with could cause tests to fail and we will have to move everything back to `daffodil-test-integration` and configure them to fork again. Thoughts? Any other ideas? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
