pkatlic commented on code in PR #1176:
URL: https://github.com/apache/daffodil/pull/1176#discussion_r1519749305
##########
daffodil-io/src/main/scala/org/apache/daffodil/io/DirectOrBufferedDataOutputStream.scala:
##########
@@ -90,53 +92,53 @@ private[io] class ByteArrayOrFileOutputStream(
throw new FileIOException(
"Unable to create temporary file in %s: %s".format(
tempDirPath.getPath,
- e.getMessage(),
+ e.getMessage,
),
)
}
val newStream: java.io.OutputStream = new
java.io.FileOutputStream(maybeFile.get)
- stream.flush
+ stream.flush()
Review Comment:
What is the best practice for inclusion of parentheses in parameterless
function calls? It seems like we don't include them for most uses (see line 95
above), but is this a special case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
