olabusayoT commented on code in PR #1065:
URL: https://github.com/apache/daffodil/pull/1065#discussion_r1529184635
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/SchemaComponentIncludesAndImportsMixin.scala:
##########
@@ -35,4 +35,6 @@ trait SchemaComponentIncludesAndImportsMixin extends
CommonContextMixin {
xmlSchemaDocument.uriString
}.toOption.getOrElse(orElseURL)
Review Comment:
I don't think this trait goes away since a lot of SchemaComponents extend
it, and it seems like a straightforward way to set diagnosticFilepath. I do
think uriString can go away as we don't seem to be using it anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
