arosien commented on PR #991: URL: https://github.com/apache/daffodil-vscode/pull/991#issuecomment-2012750291
ah, sorry all. it's difficult for me to tell the difference between the green and grey checks, they look quite similar to my eyes. i think the "Changes Approved" summary at the bottom accurately shows the green check count, i'll make sure to refer to that On Thu, Mar 21, 2024 at 4:16 AM Steve Lawrence ***@***.***> wrote: > I don't think @hdalsania <https://github.com/hdalsania> is a Daffodil > committer or PMC. Although we definitely appreciate reviews from > non-committers/PMC, and doing so is a good way to show commitment to the > project and earn the merit to become one, their votes do not count towards > the required 2 +1's ASF requires merge. The green checkmark is a good > indication of this since non-committers only get a grey checkmark when they > approve a PR. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/daffodil-vscode/pull/991#issuecomment-2011976936>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAHTO57UMNFZ3SNWWN5EJTYZK6Q5AVCNFSM6AAAAABEYOP5FGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRHE3TMOJTGY> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
