mbeckerle commented on code in PR #1187:
URL: https://github.com/apache/daffodil/pull/1187#discussion_r1534420890
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/io/InputSourceDataInputStream.scala:
##########
@@ -66,4 +66,6 @@ class InputSourceDataInputStream private[japi] (
* been consumed or some data is left-over.
*/
def hasData(): Boolean = dis.isDefinedForLength(1)
+
+ def close(): Unit = dis.close()
Review Comment:
Presumably the other places there should be closes are:
CLI when doing a non-streaming parse. Though this may be in the
dataProcessor.parse for a non-streaming parse operation. For a streaming parse
operation, when EOD on an input stream.
TDML runner and other various test rigs that create
InputSourceDataInputStreams
JAPI/SAPI examples.
Where else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
