stevedlawrence commented on code in PR #1195:
URL: https://github.com/apache/daffodil/pull/1195#discussion_r1541159649
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/dfa/Runtime.scala:
##########
@@ -147,6 +159,9 @@ trait DFADelimiter extends DFA {
final val isES = lookingFor == "%ES;"
def unparseValue: String
+
+ def strForDiagnostic = DFADelimiter.strForDiagnostic(lookingFor)
Review Comment:
Seems odd to use actual control characters instead of character class
equivalents, but I guess it's possible? Should we then change `lookingFor` so
that is the remapped version, an remap it a compile time? lookingFor seems to
be the diagnostic, or is it use for other things?
Ca we also make this a val or pass it in as a constructor paramter? We
probably shouldn't remap this everytime it ends up in diagnostics, it's normal
behavior to find an out of scope delimiter and need to create a PE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
