stevedlawrence commented on code in PR #1191:
URL: https://github.com/apache/daffodil/pull/1191#discussion_r1541583665


##########
daffodil-cli/src/main/scala/org/apache/daffodil/cli/Main.scala:
##########
@@ -901,7 +901,7 @@ object Main {
     val BadExternalVariable = Value(33)
     val UserDefinedFunctionError = Value(34)
     val UnableToCreateProcessor = Value(35)
-    val LayerExecutionError = Value(36)
+    val LayerExecutionError = Value(36) // TODO: remove if remains unused.

Review Comment:
   Ah, it looks like fatal layer errors end up with the BugFound exit code. 
While fatal layer errors are bugs, they are bugs in the layer implementation. 
It might be better to execit with LayerExecutionError jsut to make it clear 
that it's not a bug in daffodil but a bug in a layer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to