stevedlawrence commented on code in PR #129:
URL: https://github.com/apache/daffodil-site/pull/129#discussion_r1579460447
##########
site/_includes/themes/apache/default.html:
##########
@@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Apache Daffodil | {% if page.collection == "vscode" %}VS Code
Extension {% endif %}{{ page.title }}</title>
+ <title>Apache Daffodil | {% if page.collection == "vscode" %}VS Code
Extension {% endif %}{% if page.collection == "sbt" %}SBT Plugin {% endif %}{{
page.title }}</title>
Review Comment:
I imagine anything specifically Daffodil related will end up in this plugin,
but definiately something worth considering. But if we do have more, I think we
could just create a new release page and link e.g. "SBT Foo Plugin"). Might
need to rethink things if that does happen though, depends what the plugin is.
Schema Build Tool has the same acronym as simple build tool which might
cause confusion. We could say "Simple Build Tool Plugin" but that sounds a
little verbose, and if you've never heard of SBT expanding the acronym probably
wouldn't help. I'm not sure what else to call it. Any other thoughts?
Maybe "SBT Plugin" pages can have a blurb that talks a bit more about the
DFDL project layout and how SBT is used for that, so there's a bit more
description if anyone ever finds these pages?
That reminds me that we should update the g8 template and the
https://daffodil.apache.org/dfdl-layout/ page to mention thsi plugin. I'll
update this PR and create a g8 PR too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]