stricklandrbls commented on code in PR #1016:
URL: https://github.com/apache/daffodil-vscode/pull/1016#discussion_r1592789648
##########
src/dataEditor/dataEditorClient.ts:
##########
@@ -60,34 +59,35 @@ import {
ViewportEvent,
ViewportEventKind,
} from '@omega-edit/client'
+import assert from 'assert'
+import fs from 'fs'
+import net from 'net'
+import os from 'os'
import path from 'path'
+import * as vscode from 'vscode'
import XDGAppPaths from 'xdg-app-paths'
-import assert from 'assert'
-import { SvelteWebviewInitializer } from './svelteWebviewInitializer'
+import { extractDaffodilEvent } from '../daffodilDebugger/daffodil'
+import {
+ EditByteModes,
+ VIEWPORT_CAPACITY_MAX,
+} from '../svelte/src/stores/configuration'
Review Comment:
I'm confused as to why these are marked as additions. Especially the removal
of `import fs from 'fs'` on line 18 and then it's added again on line 63. Same
goes for `net`, `os`, and `vscode`...
I feel as if there's been a rebasing issue here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
