mbeckerle commented on code in PR #1254: URL: https://github.com/apache/daffodil/pull/1254#discussion_r1627833294
########## containers/release-candidate/README.md: ########## @@ -21,9 +21,9 @@ To improve reproducibility and to minimize the effects and variability of a users environment, the Daffodil release container should be used to create release candidates. -To build the Daffodil release candidate container image: +To build or update the Daffodil release candidate container image: - podman build -t daffodil-release-candidate /path/to/daffodil.git/containers/release-candidate/ + podman build -t daffodil-release-candidate https://github.com/apache/daffodil.git#main:containers/release-candidate Review Comment: This takes whatever the head of main is. Not a specific tag. Shouldn't this be taking a specific tag? Or the issue anyway is that the current state of the main branch is also subject to being "not quite the right thing" just as with a local change to the sandbox. So does this really improve things? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
